Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multiple tags on the same line of ofx file #17

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

MarkAlanJones
Copy link
Contributor

  • Add "Canadian" banking samples to tests where the file nodes do not appear on separate lines
  • adjust parser to split on < and fix up tags due to to splitting
  • deal with case where value tag with closing tag is now on two lines, due to split

Copy link
Owner

@jim-dale jim-dale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark, just a couple of very minor suggestions

src/OfxNet/Sgml/SgmlParser.cs Outdated Show resolved Hide resolved
src/OfxNet/Sgml/SgmlParser.cs Outdated Show resolved Hide resolved
src/OfxNet/Sgml/SgmlParser.cs Outdated Show resolved Hide resolved
src/OfxNet/Sgml/SgmlParser.cs Outdated Show resolved Hide resolved
src/OfxNet/Sgml/SgmlParser.cs Outdated Show resolved Hide resolved
src/OfxNet/Sgml/SgmlParser.cs Outdated Show resolved Hide resolved
src/OfxNet/Sgml/SgmlParser.cs Outdated Show resolved Hide resolved
@jim-dale jim-dale merged commit 8719f9e into jim-dale:main Dec 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants