jpmorganchase#109 Yay!!! Full compilation with errorprone and lombok …

…works!!! Full compilation with errorprone and lombok works!!! Had to follow instructions provided on https://errorprone.info/docs/installation precisely.
jimbethancourt · Jun 21, 2020 · 513a940 · 513a940
1 parent cf1c627
commit 513a940
Showing 1 changed file with 29 additions and 9 deletions.
diff --git a/pom.xml b/pom.xml
@@ -27,6 +27,7 @@
 
     <properties>
         <java.version>1.8</java.version>
+        <javac.version>9+181-r4173-1</javac.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <maven.build.timestamp.format>yyyy.MM.dd-HH.mm.ss</maven.build.timestamp.format>
         <project.build.timestamp>${maven.build.timestamp}</project.build.timestamp>
@@ -66,7 +67,7 @@
         <maven-release-plugin.version>2.5.3</maven-release-plugin.version>
         <spring.version>2.0.5.RELEASE</spring.version>
         <powermock.version>1.7.3</powermock.version>
-        <lombok.version>1.18.0</lombok.version>
+        <lombok.version>1.18.12</lombok.version>
         <errorprone.version>2.3.4</errorprone.version>
         <spotbugs.maven.plugin.version>4.0.0</spotbugs.maven.plugin.version>
         <spotbugs.version>4.0.3</spotbugs.version>
@@ -163,7 +164,6 @@
 
         </profile>
         <profile>
-            <!-- Appears to have issues with Lombok :-(-->
             <id>errorprone</id>
             <build>
                 <plugins>
@@ -174,22 +174,22 @@
                         <configuration>
                             <source>${mvn.compiler.source}</source>
                             <target>${mvn.compiler.target}</target>
-                            <compilerArgs combine.children="append">
+                            <compilerArgs>
                                 <arg>-XDcompilePolicy=simple</arg>
                                 <arg>-Xplugin:ErrorProne</arg>
-                                <arg>-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${java.version}/javac-${java.version}.jar</arg>
                             </compilerArgs>
                             <annotationProcessorPaths>
-                                <path>
-                                    <groupId>com.google.errorprone</groupId>
-                                    <artifactId>error_prone_core</artifactId>
-                                    <version>${errorprone.version}</version>
-                                </path>
                                 <path>
                                     <groupId>org.projectlombok</groupId>
                                     <artifactId>lombok</artifactId>
                                     <version>${lombok.version}</version>
                                 </path>
+                                <path>
+                                    <groupId>com.google.errorprone</groupId>
+                                    <artifactId>error_prone_core</artifactId>
+                                    <version>${errorprone.version}</version>
+                                </path>
+
                                 <!-- Add any other annotation processors here,
                                      even if they are also on the project dependency classpath. -->
                             </annotationProcessorPaths>
@@ -198,6 +198,26 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>jdk8-errorprone-addendum</id>
+            <activation>
+                <jdk>1.8</jdk>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-compiler-plugin</artifactId>
+                        <configuration>
+                            <fork>true</fork>
+                            <compilerArgs combine.children="append">
+                                <arg>-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${javac.version}/javac-${javac.version}.jar</arg>
+                            </compilerArgs>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
         <profile>
             <id>Pitest</id>
             <build>