fix: Warn when newest snapshot is in the future #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option --monitor-snapshots issues a Warning or a Critical when newest snapshot is too old based on the thresholds defined in the Sanoid configuration. However, it reports an _OK_ status when newest snapshot is in the future. This can happen when system time is wrong (in the future) for some time and then returns to normal. In such a situation, this may prevent the creation of new snapshots for a while and so we need to be alerted. Signed-off-by: Nicolas Payart <[email protected]>
phreaker0
requested changes
Apr 22, 2024
| if (defined $snapsbytype{$path}{$type}{'newest'}) { | ||
| $elapsed = $snapsbytype{$path}{$type}{'newest'}; | ||
| } | ||
| my $dispelapsed = displaytime($elapsed); | ||
| my $dispwarn = displaytime($warn); | ||
| my $dispcrit = displaytime($crit); | ||
| if ( $elapsed > $crit || $elapsed == -1) { | ||
| if ($elapsed > $crit || !defined($elapsed)) { |
There was a problem hiding this comment.
a potential undefined value is compared here and will probably trigger a warning
| @@ -181,6 +181,10 @@ sub monitor_snapshots { | |||
| if (! $config{$section}{'monitor_dont_warn'} && ($errorlevel < 2) ) { $errorlevel = 1; } | |||
| push @msgs, "WARN: $path newest $type snapshot is $dispelapsed old (should be < $dispwarn)"; | |||
| } | |||
| } elsif ($elapsed < 0) { | |||
There was a problem hiding this comment.
a potential undefined value is compared here and will probably trigger a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Option --monitor-snapshots issues a Warning or a Critical when newest snapshot is too old based on the thresholds defined in the Sanoid configuration.
However, it reports an OK status when newest snapshot is in the future. This can happen when system time is wrong (in the future) for some time and then returns to normal. In such a situation, this may prevent the creation of new snapshots for a while and so we need to be alerted.
How to test
On a Linux Debian 10 server:
Open questions