Add tests for current behaviour of --monitor-snapshots #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 17, 2022 10:05
added 21 commits
March 23, 2022 21:16
manually deleting snapshot cache
to be more accurate
these create pools in a number of states and check the output text and return code
…to add_vm_tests
monitor_dont_warn and monitor_dont_crit set
without monitor_dont_warn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message for a squash and merge:
Explanation:
I have some changes I would like to commit in another branch that adds JSON metrics output (see https://github.com/Hooloovoo/sanoid/tree/add_metrics_json and #675 ), but it involves changes to the monitor-snapshots code and I wanted to ensure I was not changing any existing behaviour, so I have added tests for the current behaviour here. This is also why I chose to write the tests in Python (in addition to that being my preferred language), as I intend to extend these tests in my JSON branch to test that the new sanoid JSON output can be correctly parsed by the Python JSON library, which is how I want to consume them to create Prometheus metrics: https://gitlab.com/aaron-w/sanoid_prometheus
I have checked that the three tests all pass (I would prefer to rename these test folders so that the quickest ones are first and the very slow one is last, so that developers can get more immediate feedback, but I did not do this in case it might break something you do in testing before release etc).