Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed deprecation warning on test #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed deprecation warning on test #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 69 additions & 69 deletions gilded_rose_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,64 +13,64 @@
context "normal item" do
Given(:name) { "NORMAL ITEM" }

Invariant { item.sell_in.should == initial_sell_in-1 }
Invariant { expect(item.sell_in).to eq(initial_sell_in-1) }

context "before sell date" do
Then { item.quality.should == initial_quality-1 }
Then { expect(item.quality).to eq(initial_quality-1) }
end

context "on sell date" do
Given(:initial_sell_in) { 0 }
Then { item.quality.should == initial_quality-2 }
Then { expect(item.quality).to eq(initial_quality-2) }
end

context "after sell date" do
Given(:initial_sell_in) { -10 }
Then { item.quality.should == initial_quality-2 }
Then { expect(item.quality).to eq(initial_quality-2) }
end

context "of zero quality" do
Given(:initial_quality) { 0 }
Then { item.quality.should == 0 }
Then { expect(item.quality).to eq(0) }
end
end

context "Aged Brie" do
Given(:name) { "Aged Brie" }

Invariant { item.sell_in.should == initial_sell_in-1 }
Invariant { expect(item.sell_in).to eq(initial_sell_in-1) }

context "before sell date" do
Then { item.quality.should == initial_quality+1 }
Then { expect(item.quality).to eq(initial_quality+1) }

context "with max quality" do
Given(:initial_quality) { 50 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end
end

context "on sell date" do
Given(:initial_sell_in) { 0 }
Then { item.quality.should == initial_quality+2 }
Then { expect(item.quality).to eq(initial_quality+2) }

context "near max quality" do
Given(:initial_quality) { 49 }
Then { item.quality.should == 50 }
Then { expect(item.quality).to eq(50) }
end

context "with max quality" do
Given(:initial_quality) { 50 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end
end

context "after sell date" do
Given(:initial_sell_in) { -10 }
Then { item.quality.should == initial_quality+2 }
Then { expect(item.quality).to eq(initial_quality+2) }

context "with max quality" do
Given(:initial_quality) { 50 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end
end
end
Expand All @@ -79,31 +79,31 @@
Given(:initial_quality) { 80 }
Given(:name) { "Sulfuras, Hand of Ragnaros" }

Invariant { item.sell_in.should == initial_sell_in }
Invariant { expect(item.sell_in).to eq(initial_sell_in) }

context "before sell date" do
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end

context "on sell date" do
Given(:initial_sell_in) { 0 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end

context "after sell date" do
Given(:initial_sell_in) { -10 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end
end

context "Backstage pass" do
Given(:name) { "Backstage passes to a TAFKAL80ETC concert" }

Invariant { item.sell_in.should == initial_sell_in-1 }
Invariant { expect(item.sell_in).to eq(initial_sell_in-1) }

context "long before sell date" do
Given(:initial_sell_in) { 11 }
Then { item.quality.should == initial_quality+1 }
Then { expect(item.quality).to eq(initial_quality+1) }

context "at max quality" do
Given(:initial_quality) { 50 }
Expand All @@ -112,91 +112,91 @@

context "medium close to sell date (upper bound)" do
Given(:initial_sell_in) { 10 }
Then { item.quality.should == initial_quality+2 }
Then { expect(item.quality).to eq(initial_quality+2) }

context "at max quality" do
Given(:initial_quality) { 50 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end
end

context "medium close to sell date (lower bound)" do
Given(:initial_sell_in) { 6 }
Then { item.quality.should == initial_quality+2 }
Then { expect(item.quality).to eq(initial_quality+2) }

context "at max quality" do
Given(:initial_quality) { 50 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end
end

context "very close to sell date (upper bound)" do
Given(:initial_sell_in) { 5 }
Then { item.quality.should == initial_quality+3 }
Then { expect(item.quality).to eq(initial_quality+3) }

context "at max quality" do
Given(:initial_quality) { 50 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end
end

context "very close to sell date (lower bound)" do
Given(:initial_sell_in) { 1 }
Then { item.quality.should == initial_quality+3 }
Then { expect(item.quality).to eq(initial_quality+3) }

context "at max quality" do
Given(:initial_quality) { 50 }
Then { item.quality.should == initial_quality }
Then { expect(item.quality).to eq(initial_quality) }
end
end

context "on sell date" do
Given(:initial_sell_in) { 0 }
Then { item.quality.should == 0 }
Then { expect(item.quality).to eq(0) }
end

context "after sell date" do
Given(:initial_sell_in) { -10 }
Then { item.quality.should == 0 }
Then { expect(item.quality).to eq(0) }
end
end

context "conjured item" do
before { pending }
Given(:name) { "Conjured Mana Cake" }

Invariant { item.sell_in.should == initial_sell_in-1 }

context "before the sell date" do
Given(:initial_sell_in) { 5 }
Then { item.quality.should == initial_quality-2 }

context "at zero quality" do
Given(:initial_quality) { 0 }
Then { item.quality.should == initial_quality }
end
end

context "on sell date" do
Given(:initial_sell_in) { 0 }
Then { item.quality.should == initial_quality-4 }

context "at zero quality" do
Given(:initial_quality) { 0 }
Then { item.quality.should == initial_quality }
end
end

context "after sell date" do
Given(:initial_sell_in) { -10 }
Then { item.quality.should == initial_quality-4 }

context "at zero quality" do
Given(:initial_quality) { 0 }
Then { item.quality.should == initial_quality }
end
end
end
# context "conjured item" do
# before { pending }
# Given(:name) { "Conjured Mana Cake" }

# Invariant { item.sell_in.should == initial_sell_in-1 }

# context "before the sell date" do
# Given(:initial_sell_in) { 5 }
# Then { item.quality.should == initial_quality-2 }

# context "at zero quality" do
# Given(:initial_quality) { 0 }
# Then { item.quality.should == initial_quality }
# end
# end

# context "on sell date" do
# Given(:initial_sell_in) { 0 }
# Then { item.quality.should == initial_quality-4 }

# context "at zero quality" do
# Given(:initial_quality) { 0 }
# Then { item.quality.should == initial_quality }
# end
# end

# context "after sell date" do
# Given(:initial_sell_in) { -10 }
# Then { item.quality.should == initial_quality-4 }

# context "at zero quality" do
# Given(:initial_quality) { 0 }
# Then { item.quality.should == initial_quality }
# end
# end
# end
end

context "with several objects" do
Expand All @@ -209,10 +209,10 @@

When { update_quality(items) }

Then { items[0].quality.should == 9 }
Then { items[0].sell_in.should == 4 }
Then { expect(items[0].quality).to eq(9) }
Then { expect(items[0].sell_in).to eq(4) }

Then { items[1].quality.should == 11 }
Then { items[1].sell_in.should == 2 }
Then { expect(items[1].quality).to eq(11) }
Then { expect(items[1].sell_in).to eq(2) }
end
end