-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use system.numerics instead of customized struct D2DPoint and D2DMatrix3x2 #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
+1 |
Given this is a fairly decent API break, are there other API changes we could includes in the next release? |
I am thinking make the Direct 1.1 support available in the next release, if possible... What do you think? |
I've commented on #60. |
In the nud2dlib fork, I've done some work to better support C#'s non-nullable-reference-types: I also fiddled around with There were also some unused resources: nikeee/nud2dlib@8ea17c3 Maybe these kinds of simplifications would be something worth to backport: If you're in on some of these, I'd be happy to file some PRs. |
Changes
System.Numerics.Vector2
instead ofD2DPoint
System.Numerics.Matrix3x2
instead ofD2DMatrix3x2
D2DSize
andVector2