Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options for icon fonts and custom HTML markup instead of icon #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EternallLight
Copy link

Hello,

I implemented the given functionality, the result looks is the following:
image

The README file and minified CSS and JS have been updated.
Please check.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 99.479% when pulling 2fb7fa1 on EternallLight:master into 9cebfda on jirikavi:master.

@Stabzs
Copy link
Collaborator

Stabzs commented Sep 28, 2017

Thank you for the pull request. This cannot be merged in without tests supporting the new functionality and withou maintaining 100% code coverage.

@EternallLight
Copy link
Author

Ok, I will write the tests in my spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants