-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reek checker plugin to detect ruby code smells #164
base: master
Are you sure you want to change the base?
Conversation
@@ -2,7 +2,7 @@ | |||
|
|||
Gem::Specification.new do |s| | |||
s.name = %q{pre-commit} | |||
s.version = "0.17.0" | |||
s.version = "0.18.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please remove the version bump from your PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not bump the version here, the core team will maintain version numbers.
edit: I missed the note above :x
@jish it would be great opportunity to make use of pre-commit-plugins |
@leonsp this change generally looks good, could you remove the version bump, and atttempt to fix the tests. |
@mpapis Do you have ideas on how should it be structured? |
extracting this to separate gem is mostly creating the same files / directories as in this PR, an extra readme, gemspec and few test files would be needed |
@leonsp please have a look into https://github.com/mpapis/pre-commit-php as an example how to create external plugins |
Thanks! I will try to set up something similar (pre-commit-reek, etc). |
now on master you can: pre-commit new plugin-name 'Author Name' author@email 'description of the plugin' this will generate scaffold for your gem - should be easy to move it from this point on, please let me know if you find any more instructions that should be added (open a new issue). |
Adds a reek check plugin. Reek is a static code analysis gem for Ruby. Unlike Rubocop, it doesn't do style, but catches several bad practices Rubocop misses.