Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support control of log level for all components #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support control of log level for all components #434

wants to merge 1 commit into from

Conversation

flecno
Copy link

@flecno flecno commented Apr 11, 2020 •
edited
Loading

This change adds support for finer log control in all components. See also #243, #241

See also handbook changes: jitsi/handbook#105

@flecno flecno changed the title WIP: support reduces log levels for all components WIP: support reduced log levels for all components Apr 11, 2020
@flecno flecno force-pushed the support-log-levels branch 3 times, most recently from c7cc8a3 to 5bc5bd8 Compare April 13, 2020 14:32
@flecno flecno marked this pull request as ready for review April 13, 2020 14:33
@flecno flecno changed the title WIP: support reduced log levels for all components support control of log level for all components Apr 13, 2020
@flecno flecno mentioned this pull request Apr 13, 2020
Closed
saghul
saghul requested changes Apr 14, 2020
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thanks for contributing this!

env.example Show resolved Hide resolved
etherpad.yml Show resolved Hide resolved
jibri/rootfs/defaults/config.json Show resolved Hide resolved
web/rootfs/defaults/nginx.conf
access_log /dev/stdout;
{{ else }}
access_log off;
{{ end }}
error_log /dev/stderr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also want to disable error logging perhaps?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add custom log levels for the web containers as well? Info would include access logs, warn or error would include error logs, and none/false would deactivate both.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added support for more levels

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think? Is that useful?

@flecno
Copy link
Author

flecno commented Apr 27, 2020

@saghul can you please review again? I want to get this into master 😋

luixxiul
luixxiul reviewed May 20, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@luixxiul
Copy link
Contributor

This also needs rebase.

@saghul saghul mentioned this pull request Sep 15, 2020
Closed
@PhilippeAccorsi
Copy link

Hi,

Can you explain what done this command tpl, when you replace cp /defaults/nginx.conf /config/nginx/nginx.conf by tpl /defaults/nginx.conf > /config/nginx/nginx.conf ?

Thanks.
Philippe

@saghul
Copy link
Member

saghul commented Oct 20, 2020

@PhilippeAccorsi That's a little helper templating tool we use.

flecno added a commit to flecno/handbook that referenced this pull request Oct 27, 2020
@flecno
Add docker log level options added in jitsi/docker-jitsi-meet#434
92d2410
@flecno flecno force-pushed the support-log-levels branch from 2164d75 to abaa85a Compare October 27, 2020 20:33
@flecno flecno mentioned this pull request Oct 27, 2020
Open
@flecno
Copy link
Author

flecno commented Oct 27, 2020

I have finally rebased my changes on latest master and added the README changes to the handbook: jitsi/handbook#105

@flecno flecno force-pushed the support-log-levels branch 2 times, most recently from 5a347b6 to acc73f1 Compare November 1, 2020 17:37
@flecno flecno force-pushed the support-log-levels branch from acc73f1 to 942bd17 Compare November 10, 2020 21:53
@flecno
Copy link
Author

flecno commented Nov 10, 2020

Rebased again

@flecno
Copy link
Author

flecno commented Feb 14, 2021 •
edited
Loading

Hey @saghul, do you see any chance to get this merged if I rebase this again?

@JannikEmmerich
Copy link

@saghul What's the status on this?

@saghul
Copy link
Member

saghul commented Sep 17, 2021

Sorry, this fell through the cracks :-/ It needs a rebase though.

@cryptoluks
Copy link

Workaround:

docker exec -it jitsi_jicofo_1 sh -c 'sed -i "s/^.level=.*/.level=WARNING/" /defaults/logging.properties'
docker exec -it jitsi_jvb_1 sh -c 'sed -i "s/^.level=.*/.level=WARNING/" /defaults/logging.properties'
docker-compose restart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapkra sapkra sapkra left review comments

@luixxiul luixxiul luixxiul left review comments

@valkum valkum valkum left review comments

@saghul saghul saghul requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@flecno @luixxiul @PhilippeAccorsi @saghul @JannikEmmerich @cryptoluks @valkum @sapkra