Fix the nginx proxy configuration and improve the reverse proxy documentation #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The proxy for / was missing - The paths were wrong (for instance /xmpp-websocket was proxied to / instead of /xmpp-websocket) - Reorganize the reverse proxy paragraph to factorize the explanations regarding the fact we proxy to HTTP and not HTTPS
The proxy_http module was missing
damencho
approved these changes
Oct 26, 2024
saghul
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consecutively to my previous pull request #533 I took some time to setup an nginx server and tried the proxy configuration.
This enabled me to fix multiple things:
/http-bind/xmpp-websocketmust target/xmpp-websocketand not/)/)This configuration seems to work as expected.
I also reorganized the reverse proxy paragraph in order to share between Apache and nginx the explanation I added in my previous PR regarding the usage of HTTP instead of HTTPS and how to disable HTTPS.
I also added a required module for Apache (
proxy_http).Hope this will help!