Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten bitrate calculation window to adapt for bandwidth changes faster #296

Closed
wants to merge 1 commit into from

Conversation

dsmeytis
Copy link
Contributor

This PR is related to PR#1439. It would be better to reduce bitrate calculator back window in order to speed up RateStatistics warm-up period and reach minimal bitrate threshold faster.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@bgrozev
Copy link
Member

bgrozev commented Sep 23, 2020

@dsmeytis Thank you for the contribution and sorry for the slow response. I don't feel comfortable reducing the window size this much without testing, but #305 will allow you to easily configure it for your environment. Does that work for you?

@dsmeytis
Copy link
Contributor Author

dsmeytis commented Oct 5, 2020

Hi, @bgrozev. Yes, that's good opportunity to configure window. So this PR is obsolete now. thank you.

@dsmeytis dsmeytis closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants