Improve handling of full items #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yeah, fixes #293 as well |
anarcat
suggested changes
Jan 31, 2020
| @@ -176,6 +181,10 @@ def main(argv, session): | |||
| 'Expect 503 SlowDown errors.'.format(args['<identifier>']), | |||
| file=sys.stderr) | |||
| sys.exit(1) | |||
| elif get_item('{0}'.format(args['<identifier>'])).item_size >= 1099511627776: | |||
There was a problem hiding this comment.
could we use a global, in capitals, at the top of the file here instead of this magic number? something like:
IA_MAX_SIZE = 1099511627776
or even better, what the actual value means:
# one tibibyte
IA_MAX_SIZE = 2^40
There was a problem hiding this comment.
I agree with @anarcat. Also, we already initialize the item on https://github.com/jjjake/internetarchive/blob/master/internetarchive/cli/ia_upload.py#L183, this check should happen after that so we only have to do it once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a warning message when an upload fails due to a ConnectionError, as is the case when the item is full.
--status-checknow checks for this. These two changes make the underlying issue in #290 more clear.This is just about the minimum useful PR I could put together in a short time. I'm not really familiar with all the different uses of
ia, so wasn't really sure how to properly signal the failure of a single upload for bulk uploads and the like. I'd like to improve on this later if time allows, but this is better than nothing.