Add an insufficient-permissions error code for similarCards.

Part of #646.
jkomoros · Nov 14, 2023 · 79fa356 · 79fa356
1 parent 7e51902
commit 79fa356
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/functions/src/embeddings.ts b/functions/src/embeddings.ts
@@ -479,7 +479,15 @@ export const similarCards = async (request : CallableRequest<SimilarCardsRequest
 
 	if (data.card) {
 		//We will hit the openai endpoint, so verify we're allowed.
-		await throwIfUserMayNotUseAI(request);
+		try {
+			await throwIfUserMayNotUseAI(request);
+		} catch(err) {
+			return {
+				success: false,
+				code: 'insufficient-permissions',
+				error: String(err)
+			};
+		}
 
 		if (data.card.id != data.card_id) throw new Error(`Card.id was ${data.card.id} which did not match card_id: ${data.card_id}`);
 

diff --git a/functions/src/types.ts b/functions/src/types.ts
@@ -203,7 +203,7 @@ export type CardSimilarityItem = [CardID, number];
 //Replicated in `src/actions/similarity.ts`
 export type SimilarCardsResponseData = {
 	success: false,
-	code: 'qdrant-disabled' | 'no-embedding' | 'stale-embedding' | 'unknown'
+	code: 'qdrant-disabled' | 'insufficient-permissions' | 'no-embedding' | 'stale-embedding' | 'unknown'
 	error: string
 } | {
 	success: true

diff --git a/src/actions/similarity.ts b/src/actions/similarity.ts
@@ -64,7 +64,7 @@ type CardSimilarityItem = [CardID, number];
 //Replicated in `functions/src/types.ts`
 type SimilarCardsResponseData = {
 	success: false,
-	code: 'qdrant-disabled' | 'no-embedding' | 'stale-embedding' | 'unknown'
+	code: 'qdrant-disabled' | 'insufficient-permissions' | 'no-embedding' | 'stale-embedding' | 'unknown'
 	error: string
 } | {
 	success: true