Make it so verifySeedPacket takes a location to make better warnings.

Part of #39.
jkomoros · Jul 8, 2023 · 0e2cd11 · 0e2cd11
1 parent 7e57a16
commit 0e2cd11
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/garden.ts b/src/garden.ts
@@ -170,7 +170,7 @@ export class Garden {
 		seedPacket.parse(packet);
 		const expandedPacket = expandSeedPacket(packet);
 		//This will throw if there are errors in the packet.
-		const warnings = verifySeedPacket(expandedPacket);
+		const warnings = verifySeedPacket(location, expandedPacket);
 		if (!this._location) this._location = location;
 		for (const [id, seed] of Object.entries(expandedPacket.seeds)) {
 			const ref : AbsoluteSeedReference = {

diff --git a/src/seed.ts b/src/seed.ts
@@ -228,7 +228,7 @@ const collectSeedReferences = (data : ExpandedSeedData) : SeedReference[] => {
 
 //Will throw an error if an error is found. Will return an array of errors
 //representing warnings for less significant problems.
-export const verifySeedPacket = (packet : ExpandedSeedPacket) : Error[] | null => {
+export const verifySeedPacket = (location: SeedPacketAbsoluteLocation, packet : ExpandedSeedPacket) : Error[] | null => {
 	const warnings : Error[] = [];
 	//First sanity check we typecheck, throwing if not.
 	seedPacket.parse(packet);
@@ -240,7 +240,7 @@ export const verifySeedPacket = (packet : ExpandedSeedPacket) : Error[] | null =
 			if (!packet.seeds[ref.seed]) throw new Error(`Seed ${id} referenced a non-existent local seed: ${ref.seed}`);
 		}
 	}
-	if (!packet.environment || !packet.environment.namespace) warnings.push(new Error('namespace is not set. Setting a namespace is recommended'));
+	if (!packet.environment || !packet.environment.namespace) warnings.push(new Error(`namespace is not set in ${location}. Setting a namespace is recommended`));
 	return warnings.length ? warnings : null;
 };