Merge pull request #405 from jkroepke/fix-multiline

CHANGELOG.md

@@ -8,7 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 ### Added
-- `secrets+*-import://` added syntax checks 
+- `secrets+*-import://` added syntax checks
+
+### Fixed
+- Multiline parameter values 
 
 ## [4.5.0] - 2023-08-14
 

scripts/commands/helm.sh

@@ -66,12 +66,24 @@ helm_wrapper() {
 
             decrypted_literals=""
 
-            IFS='
-'
+            IFS=","
+            _literal=""
 
-            for literal in $(printf '%s' "${literals}" | sed -E 's/([^\\]),/\1\n/g'); do
+            for literal in ${literals}; do
                 unset IFS
 
+                case "${literal}" in
+                *\\)
+                    _literal="${literal}"
+                    continue
+                    ;;
+                esac
+
+                if [ "${_literal}" != "" ]; then
+                    literal="${_literal},${literal}"
+                    _literal=""
+                fi
+
                 opt_prefix="${literal%%=*}="
                 literal="${literal#*=}"
 

tests/unit/template.bats

@@ -169,6 +169,28 @@ load '../bats/extensions/bats-file/load'
     assert_file_not_exists "${VALUES_PATH}.dec"
 }
 
+@test "template: helm template w/ chart + secrets.yaml + helm flag + multiline" {
+    if on_windows; then
+        skip
+    fi
+
+    VALUES="assets/values/${HELM_SECRETS_BACKEND}/secrets.yaml"
+    VALUES_PATH="${TEST_TEMP_DIR}/${VALUES}"
+
+    create_chart "${TEST_TEMP_DIR}"
+
+    run "${HELM_BIN}" secrets template "${TEST_TEMP_DIR}/chart" -f "${VALUES_PATH}" --set "podAnnotations.second=key1:
+key2: value" 2>&1
+
+    assert_output -e "\[helm-secrets\] Decrypt: .*${VALUES}"
+    assert_output --partial "port: 81"
+    assert_output --partial "key1:"
+    assert_output --partial "key2: value"
+    assert_output -e "\[helm-secrets\] Removed: .*${VALUES}.dec"
+    assert_success
+    assert_file_not_exists "${VALUES_PATH}.dec"
+}
+
 @test "template: helm template w/ chart + not-exists.yaml" {
     VALUES="not-exists.yaml"
     VALUES_PATH="${VALUES}"