fixed a bug in the Venice PDF cheatsheet generation

the doc section header was not rendered in the right doc section column
jlangch · Sep 4, 2024 · 016627d · 016627d
1 parent 0a23c86
commit 016627d
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 5 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -4,7 +4,9 @@
 All notable changes to this project will be documented in this file.
 
 
-## [1.12.33] - 2024-08-xx
+
+
+## [1.12.34] - 2024-09-xx
 
 ### Added
 
@@ -14,6 +16,20 @@ All notable changes to this project will be documented in this file.
 - :openai module support for assistant run api (...)
 - :openai module support for assistant run steps api (...)
 
+
+
+## [1.12.33] - 2024-09-xx
+
+### Added
+
+- function `add-conditional-bg-color` to :excel module
+- function `add-text-data-validation` to :excel module
+
+### Fixed
+
+- a bug in the Venice PDF cheatsheet generation where the doc section header was 
+  not rendered in the right doc section column.
+
 ### Updated dependencies:
 
 - Bumped Apache POI from 5.2.3 to 5.3

diff --git a/...ain/java/com/github/jlangch/venice/impl/docgen/cheatsheet/modules/ModuleExcelSection.java b/...ain/java/com/github/jlangch/venice/impl/docgen/cheatsheet/modules/ModuleExcelSection.java
@@ -44,12 +44,11 @@ public DocSection section() {
 
         final DocSection section = new DocSection(
                                         "Excel",
-                                        "Read/Write Excel files. \n\n" +
-                                        "Venice is compatible with Apache POI 4.1.x and 5.3.x. " +
+                                        "Read/Write Excel files",
+                                        "modules.excel",
+                                        "Venice is compatible with Apache POI 4.1.x and 5.3.x.\n\n" +
                                         "To use charts with Excel documents Apache POI 5.2.0 or " +
                                         "newer is required.",
-                                        "modules.excel",
-                                        null,
                                         footer);
 
         final DocSection all = new DocSection("(load-module :excel)", id());
@@ -78,6 +77,7 @@ public DocSection section() {
         sheet.addItem(diBuilder.getDocItem("excel/add-column", false));
         sheet.addItem(diBuilder.getDocItem("excel/add-merge-region", false));
         sheet.addItem(diBuilder.getDocItem("excel/add-conditional-bg-color", false));
+        sheet.addItem(diBuilder.getDocItem("excel/add-conditional-font-color", false));
         sheet.addItem(diBuilder.getDocItem("excel/add-text-data-validation", false));
         sheet.addItem(diBuilder.getDocItem("excel/freeze-pane", false));
         sheet.addItem(diBuilder.getDocItem("excel/auto-size-columns", false));
@@ -144,6 +144,7 @@ public DocSection section() {
         style.addItem(diBuilder.getDocItem("excel/add-style", false));
         style.addItem(diBuilder.getDocItem("excel/add-merge-region", false));
         style.addItem(diBuilder.getDocItem("excel/add-conditional-bg-color", false));
+        style.addItem(diBuilder.getDocItem("excel/add-conditional-font-color", false));
         style.addItem(diBuilder.getDocItem("excel/row-height", false));
         style.addItem(diBuilder.getDocItem("excel/col-width", false));
         style.addItem(diBuilder.getDocItem("excel/cell-style", false));

diff --git a/src/main/resources/com/github/jlangch/venice/docgen/cheatsheet2.html b/src/main/resources/com/github/jlangch/venice/docgen/cheatsheet2.html
@@ -686,6 +686,11 @@ <h2>${= (kira/escape-xml (:title s1)) }$</h2>
                       <h2>${= (kira/escape-xml (:title s1)) }$</h2>
                       ${ (when (:subtitle s1) }$<h3>${= (kira/escape-xml (:subtitle s1)) }$</h3>${ ) }$
                     </div>
+                    ${ (when-not (empty? (:headerXmlStyled s1)) }$
+                    <div class="header">
+                      ${= (:headerXmlStyled s1) }$
+                    </div>
+                    ${ ) }$                 
                     ${ (doseq [s2 (:sections s1)] }$
                     ${ (when (:title s2) }$<div class="sub-header-module" id="${= (:id s2) }$">${= (kira/escape-xml (:formattedTitle s2)) }$</div>${ ) }$
                     <table>