Fixed CSV writer quoting

jlangch · Oct 31, 2023 · 278cbbb · 278cbbb
1 parent ff9993f
commit 278cbbb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/main/java/com/github/jlangch/venice/impl/util/csv/CSVWriter.java b/src/main/java/com/github/jlangch/venice/impl/util/csv/CSVWriter.java
@@ -132,7 +132,7 @@ private String escape(final String s) {
                     curr = pos + 1;
                 }
                 else {
-                    sb.append(s.substring(pos));
+                    sb.append(s.substring(curr));
                     break;
                 }
                 pos = s.indexOf(quote, curr);
@@ -146,7 +146,10 @@ private String quote(final String s) {
     }
 
     private boolean needsQuote(final String s) {
-        return s != null && (s.contains(" ") || s.contains(quote) || s.contains(separator));
+        return s != null && (s.contains(" ")
+        						|| s.contains(quote)
+        						|| s.contains(separator)
+        						|| s.contains(newline));
     }