Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #452: BR URLs updated to https from http to avoid 503 results #453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #452: BR URLs updated to https from http to avoid 503 results #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e45e19
Issue #452: BR URLs updated to https from http to avoid 503 results
blue-shoes Sep 8, 2024
1a70af8
Remove print output from league_batting_stats
blue-shoes Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pybaseball/league_batting_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def get_soup(start_dt: date, end_dt: date) -> BeautifulSoup:
# if((start_dt is None) or (end_dt is None)):
# print('Error: a date range needs to be specified')
# return None
url = "http://www.baseball-reference.com/leagues/daily.cgi?user_team=&bust_cache=&type=b&lastndays=7&dates=fromandto&fromandto={}.{}&level=mlb&franch=&stat=&stat_value=0".format(start_dt, end_dt)
url = "https://www.baseball-reference.com/leagues/daily.cgi?user_team=&bust_cache=&type=b&lastndays=7&dates=fromandto&fromandto={}.{}&level=mlb&franch=&stat=&stat_value=0".format(start_dt, end_dt)
s = session.get(url).content
# a workaround to avoid beautiful soup applying the wrong encoding
s = s.decode('utf-8')
Expand Down Expand Up @@ -92,7 +92,7 @@ def bwar_bat(return_all: bool = False) -> pd.DataFrame:
Get data from war_daily_bat table. Returns WAR, its components, and a few other useful stats.
To get all fields from this table, supply argument return_all=True.
"""
url = "http://www.baseball-reference.com/data/war_daily_bat.txt"
url = "https://www.baseball-reference.com/data/war_daily_bat.txt"
s = session.get(url).content
c=pd.read_csv(io.StringIO(s.decode('utf-8')))
if return_all:
Expand All @@ -101,4 +101,4 @@ def bwar_bat(return_all: bool = False) -> pd.DataFrame:
cols_to_keep = ['name_common', 'mlb_ID', 'player_ID', 'year_ID', 'team_ID', 'stint_ID', 'lg_ID',
'pitcher','G', 'PA', 'salary', 'runs_above_avg', 'runs_above_avg_off','runs_above_avg_def',
'WAR_rep','WAA','WAR']
return c[cols_to_keep]
return c[cols_to_keep]
4 changes: 2 additions & 2 deletions pybaseball/league_pitching_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def get_soup(start_dt: Optional[Union[date, str]], end_dt: Optional[Union[date,
if((start_dt is None) or (end_dt is None)):
print('Error: a date range needs to be specified')
return None
url = "http://www.baseball-reference.com/leagues/daily.cgi?user_team=&bust_cache=&type=p&lastndays=7&dates=fromandto&fromandto={}.{}&level=mlb&franch=&stat=&stat_value=0".format(start_dt, end_dt)
url = "https://www.baseball-reference.com/leagues/daily.cgi?user_team=&bust_cache=&type=p&lastndays=7&dates=fromandto&fromandto={}.{}&level=mlb&franch=&stat=&stat_value=0".format(start_dt, end_dt)
s = session.get(url).content
# a workaround to avoid beautiful soup applying the wrong encoding
s = s.decode('utf-8')
Expand Down Expand Up @@ -96,7 +96,7 @@ def bwar_pitch(return_all: bool=False) -> pd.DataFrame:
Get data from war_daily_pitch table. Returns WAR, its components, and a few other useful stats.
To get all fields from this table, supply argument return_all=True.
"""
url = "http://www.baseball-reference.com/data/war_daily_pitch.txt"
url = "https://www.baseball-reference.com/data/war_daily_pitch.txt"
s = session.get(url).content
c = pd.read_csv(io.StringIO(s.decode('utf-8')))
if return_all:
Expand Down
2 changes: 1 addition & 1 deletion pybaseball/standings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
session = BRefSession()

def get_soup(year: int) -> BeautifulSoup:
url = f'http://www.baseball-reference.com/leagues/MLB/{year}-standings.shtml'
url = f'https://www.baseball-reference.com/leagues/MLB/{year}-standings.shtml'
s = session.get(url).content
return BeautifulSoup(s, "lxml")

Expand Down
2 changes: 1 addition & 1 deletion pybaseball/team_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def get_soup(season: Optional[int], team: str) -> BeautifulSoup:
# get most recent year's schedule if year not specified
if season is None:
season = most_recent_season()
url = "http://www.baseball-reference.com/teams/{}/{}-schedule-scores.shtml".format(team, season)
url = "https://www.baseball-reference.com/teams/{}/{}-schedule-scores.shtml".format(team, season)
print(url)
s = session.get(url).content
return BeautifulSoup(s, "lxml")
Expand Down