Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop fusesource jansi #1056

Closed
wants to merge 1 commit into from
Closed

Conversation

cstamas
Copy link
Contributor

@cstamas cstamas commented Aug 13, 2024

Replace everything in JLine with jansi-core own module. Also, some fixes made, as interpolation did not happen, etc.

Changes:

  • Dependency on org.fusesource:jansi is dropped. The project should go into oblivion.
  • Changed JLine classes to use "our" JAnsi
  • jansi-core (and jansi bundle) made "drop in replacement"

Replace everything in JLine with jansi-core own module.
Also, some fixes made, as interpolation did not happen,
etc.
@gnodet
Copy link
Member

gnodet commented Aug 15, 2024

I did not really want to keep the same package name, as I'm not 100% sure it can actually be used as a drop-in replacement. The dependencies and setup are quite different.

@cstamas
Copy link
Contributor Author

cstamas commented Aug 15, 2024

So should I drop the org/fusesource classes then? Is the rest of change (drop of Jansi) ok?

@gnodet
Copy link
Member

gnodet commented Aug 15, 2024

So should I drop the org/fusesource classes then?

I'd rather keep the package rename.

Is the rest of change (drop of Jansi) ok?

Imho they are consistent with the fact that I did not renamed the package. The jansi provider is using the "old jansi". The "new jansi" is built on top of jline, so we can't use it as a provider, it would not make sense. I plan to deprecate the "jansi" and "jna" providers soon, as "jni" and "ffm" are the ones that should be used.

@cstamas cstamas marked this pull request as draft August 27, 2024 21:43
@gnodet gnodet closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants