Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use sarif tools for clippy annotations #69

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jmagnuson
Copy link
Owner

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #69 (0268f68) into master (d3b6bc9) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   96.04%   95.61%   -0.43%     
==========================================
  Files           3        3              
  Lines         657      661       +4     
==========================================
+ Hits          631      632       +1     
- Misses         26       29       +3     
Impacted Files Coverage Δ
src/reader.rs 96.15% <0.00%> (-0.46%) ⬇️

... and 1 file with indirect coverage changes

pub fn is_transient(&self) -> bool {
let a_thing = 0usize;

Check failure

Code scanning / clippy

unused variable: a_thing Error

unused variable: a\_thing
pub fn is_transient(&self) -> bool {
let a_thing = 0usize;

Check failure

Code scanning / clippy

unused variable: a_thing Error

unused variable: a\_thing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant