Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved two issues: added support for MKV files and clarified "error" printed output #461

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    a620e70 View commit details
    Browse the repository at this point in the history
  2. updated and verified code to change result message

    there is now a new type of result, duplicate files
    these are files that already exist in the destination
    folder and are not imported if not importing duplicates
    
    I have thoroughly verified that my changes do not cause
    any other part of the code to break or act in an
    unexpected manner. I have also removed some code
    that could never get used:
    elodie/localstorage.py: checksum() could never return None,
    code was not accessible due to earlier return
    because of this:
    elodie/filesystem.py: process_checksum() did not need
    to check if checksum was None after calculating it
    this is what allowed my new code to use None
    as a flag meaning that the file being imported and skipped
    is a duplicate file
    Cedric-Boucher committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    651c373 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6953b7a View commit details
    Browse the repository at this point in the history
  4. updated test cases

    Cedric-Boucher committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    996bc6a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    549ae5e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fd2d264 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    432ae0b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2d59391 View commit details
    Browse the repository at this point in the history
  9. exiftool also supports webm, adding to recognized

    video file extensions
    Cedric-Boucher committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    6eef036 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0b6a682 View commit details
    Browse the repository at this point in the history
  11. added webp and svg to recognized photo types

    as they are supported by exiftool
    Cedric-Boucher committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    6e946d6 View commit details
    Browse the repository at this point in the history