Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referenced images inserted directly #264

Closed
wants to merge 6 commits into from

Conversation

ft-lie
Copy link

@ft-lie ft-lie commented Dec 2, 2020

ref #263
Adding option to insert image directly, and not only via filename.

my $png = make_png();
$worksheet3->insert_image( 'A1',  \$png);

@jmcnamara
Copy link
Owner

That is something I could (should) add. The Python and C versions of this library support it but no-one asked for it in the Perl version (which predates the others) so I never added it.

I'll close the PR, since this isn't the way I would implement it, but will leave the Feature Request open.

Thanks for the suggestion and PR.

@jmcnamara jmcnamara closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants