Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up post-Hijack code #530

Open
jmhodges opened this issue Jul 9, 2023 · 0 comments
Open

clean up post-Hijack code #530

jmhodges opened this issue Jul 9, 2023 · 0 comments

Comments

@jmhodges
Copy link
Owner

jmhodges commented Jul 9, 2023 •
edited
Loading

We should rename hijackHandle and fix up the logging in it to include the new name. Or refactor the JSON API and HTML handlers to not use a central func anymore since the new code needs much less handholding
jmhodges added a commit that referenced this issue Jul 9, 2023
@jmhodges
use statWriter in ClientInfo handler
a008de2 
Now that we don't rely on hijack, we can use the statWriter to write our
metrics.

This probably would be better a deeper integration of our tracing work,
but this at least makes the metrics consistent.

Updates #530
jmhodges added a commit that referenced this issue Jul 9, 2023
@jmhodges
use statWriter in ClientInfo handler
74379fe 
Now that we don't rely on hijack, we can use the statWriter to write our
metrics.

This probably would be better a deeper integration of our tracing work,
but this at least makes the metrics consistent.

Updates #530
@jmhodges jmhodges mentioned this issue Jul 9, 2023
Merged
jmhodges added a commit that referenced this issue Jul 9, 2023
@jmhodges
use statWriter in ClientInfo handler (#535)
3caa7f0 
Now that we don't rely on Hijack, we can use the statWriter to write our
metrics.

This probably would be better a deeper integration of our tracing work,
but this at least makes the metrics consistent.

Updates #530
jmhodges added a commit that referenced this issue Jul 9, 2023
@jmhodges
rename hijackHandle and comment logHandler
b865740 
Now that the Hijack is gone, we pick another name for the core handling
func.

And while we're here, we comment about logHandler being replacable.

Updates #530
Updates #537
@jmhodges jmhodges mentioned this issue Jul 9, 2023
Merged
jmhodges added a commit that referenced this issue Jul 9, 2023
@jmhodges
rename hijackHandle and comment logHandler (#538)
4c15577 
Now that the Hijack is gone, we pick another name for the core handling
func.

And while we're here, we comment about logHandler being replacable.

Updates #530
Updates #537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmhodges