use statWriter in ClientInfo handler #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we don't rely on hijack, we can use the statWriter to write our metrics. This probably would be better a deeper integration of our tracing work, but this at least makes the metrics consistent. Updates #530
jmhodges
force-pushed
the
clean-up-hijack-stat-writer
branch
from
a008de2 to
74379fe
Compare
jmhodges
changed the title
jmhodges
added a commit
that referenced
this pull request
Jul 9, 2023
jmhodges
added a commit
that referenced
this pull request
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we don't rely on hijack, we can use the statWriter to write our
metrics.
This probably would be better a deeper integration of our tracing work,
but this at least makes the metrics consistent.
Updates #530