Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for <caption /> #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

phlbnks
Copy link

@phlbnks phlbnks commented Nov 20, 2013

<caption /> is a valid element within <table /> and (imo) should be treated as part of the head and made sticky.

<caption /> is a valid element within <table />
@phlbnks
Copy link
Author

phlbnks commented Nov 20, 2013

(JS isn't my first language so my code can probably be refined, but it's functional in my tests.)

@jmosbech
Copy link
Owner

Thanks for contributing!

Previously I've had issues with calculating the width of the caption tag, but I'll give your code a spin to see if it works out.

Best
Jonas

@phlbnks
Copy link
Author

phlbnks commented Nov 25, 2013

No problem - thanks for the great script!
If you find this has the same problems let me know how to replicate them and I’ll try and make time to work on it.

Cheers,
Phil

On 21 Nov 2013, at 19:36, Jonas Mosbech [email protected] wrote:

Thanks for contributing!

Previously I've had issues with calculating the width of the caption tag, but I'll give your code a spin to see if it works out.

Best
Jonas


Reply to this email directly or view it on GitHub.

@ericscheid
Copy link

ericscheid commented Jun 21, 2017

Does this work even if the <caption> is hidden? This sometimes happens when the caption is provided for accessibility support but is otherwise not visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants