Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add playlist metadata download item during migration #905

Open
wants to merge 1 commit into
base: redesign
Choose a base branch
from

Conversation

Chaphasilor
Copy link
Collaborator

This enhances the user experience when adding tracks from playlists (as it shows which playlists the track is already part of), enables removing tracks from playlists using the playlist actions menu, and shows partially downloaded playlists in offline mode.

@Chaphasilor
Copy link
Collaborator Author

@Komodo5197 would you mind taking a look? I'll still have to test this out to see if it actually works, but maybe there's something that could be improved with the download code already ^^

@Komodo5197
Copy link

That seems about as I expected. I don't 100% remember how this migration script works when conducting the initial login, so definitely test that. Also, it might make more sense to chain the future so that the playlist download gets added before we start the repair, although this probably doesn't really matter.

@Chaphasilor
Copy link
Collaborator Author

From what I saw there's a hidden setting that is false by default and gets set to true after the migration, so it should be fine.

I thought about that, but wanted to prioritize the migration of existing downloads over the metadata. Is the download system even a proper FIFO queue?
Either way, I haven't decided on the final order yet. Might try out different approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants