Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary template-registry.js export in rollup.config.mjs #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkszepp
Copy link

@mkszepp mkszepp commented Feb 3, 2024

This is fixing a warning while rollup & also a unnecessary file on npm

../ember-truth-helpers prepare: [js] (!) Generated an empty chunk
../ember-truth-helpers prepare: [js] "template-registry"

grafik

@SergeAstapov
Copy link
Collaborator

@mkszepp this is not correct change as you would not be able to do import type EmberTruthRegistry from 'ember-truth-helpers/template-registry'; in the consumer app or addon

@mkszepp
Copy link
Author

mkszepp commented Aug 23, 2024

@SergeAstapov i don't agree... the file in dist/template-registry is empty like you see in screenshot...

The import is only for typing and typing is using only file of declaration/template-registry

The rule in package.json makes possibile to use it, you don't need it to add it in rollup file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants