Fix multibyte unicode support #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use escape() to percentage encode the final reconstructed string to percentage encode the string's bytes, and then decodeURIComponent() to properly handle unicode characters (as explained in https://blog.jse.li/posts/cloudflare-scrape-shield/).
Fix `TypeError: Cannot read property 'parentNode' of null` bug
- No longer necessary in modern browsers - Ensures the enkoder still works when used with scripts that compact source code and strip out comments
Remove comments before and after inserted JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enkoder does not currently support multibyte characters such as
’. For example, encodingdon’tresults indonâ��t.This pull request adds full support for unicode characters (including Emoji 😀). It is based on CloudFlare’s solution and uses
escape()to percentage encode the final reconstructed string's bytes, and thendecodeURIComponent()to properly handle unicode characters.