-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
javadoc: add support for tparam #210
Conversation
The same also be done for |
I'll share some of my thoughts around this. First, I don't mind merging this, or further improvements to the currently a bit clumsy Javadoc support. However, if there are more things to come, I might like copying the Javadoc code from Finally, if you don't specifically need Javadoc/Doxygen style comments (and I acknowledge there are valid reasons to stick to them) I'd always urge people to use reStructuredText directly. The conversion will always be a potential failure point, especially since reStructuredText is fussy about whitespace and indentation. |
9165bc0
to
c5fb218
Compare
Sounds reasonable. I extended the MR for the other keywords, feel free to move to code wherever.
While I do fully agree, this is unfortunately not really an option. |
c5fb218
to
8701094
Compare
Okay, I fully acknowledge this is not the way to treat contributors... and I'm sorry. But in the end I decided the current javadoc/doxygen parser is just too hard to extend or maintain properly. So here's an overhauled parser: #216. It should cover what you ask here, and much, much, more. I haven't written tests for it yet (besides what we already have), but I've looked at the results manually. Would you mind giving it a spin, please? Oh, one thing it doesn't do is |
No worries!
Wow, that PR seems amazing! I will find some time to go through the code and test it out!
throws => throw => exception according to doxygen documentation |
I merged #216 after some improvements. Closing this one. Please check it out and file issues and/or improve on it! |
Documentation of template parameters is supported in both doxygen and sphinx, so let's add it to the javadoc converter.
https://www.doxygen.nl/manual/commands.html#cmdtparam
https://www.sphinx-doc.org/en/master/usage/domains/cpp.html#info-field-lists