Unify -x<language> option usage #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the domain is handled indirectly via -x<language> option in clang_args, but prepare for moving the option at a lower level.
Currently the domain is handled indirectly via -x<language> option in clang_args, but prepare for moving the option at a lower level.
Have a single point of truth for setting the clang -x<language> option, to unify parsing across the extension, tests, and cli. Choose the language primarily based on the domain, and secondarily based on the filename extension to differentiate headers. Using "-header" is necessary for some cases such as "#pragma once", where plain "-xc" or "-xc++" would interpret the file as a main file. This unconditionally bypasses libclang automatic detection. The user and tests can still override the parser selected language, as the user provided clang_args are appended. Fixes: #208
This was referenced Nov 9, 2023
|
Looks great! |
Thanks; I additionally pushed some tests that would fail without the fixes in the series. Would you mind eyeballing them too, please? |
BrunoMSantos
reviewed
Nov 9, 2023
jnikula
force-pushed
the
clang-language-option
branch
from
c29ec87 to
15147ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the clang language selection at a lower level, do it unconditionally, and add -header too. This unifies -x option across the extension, tests ,and cli.
Fixes #208