-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process docstring cli testing #215
Conversation
It's not easy to adapt the Sphinx extensions for usage in the cli or parser tests without Sphinx. Instead, add direct process_docstring() functions for the simple use cases without extension setup or configuration.
Move away from doccompat, and use the extensions for docstring processing.
Add --process-docstring option to use the extension for docstring processing. Leave the --compat option in place for now, but we might want to deprecate and remove it going forward.
Now that the cli supports --process-docstring, we can handle transform also in the cli tests, and skip two fewer tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ;)
'javadoc-basic', | ||
'javadoc-liberal', | ||
'kernel-doc' | ||
], | ||
help='Compatibility options. See cautodoc_compat.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider raising DeprecationWarning
🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: we may also want to institutionalize a deprecation policy so we have a regular, well advertised schedule for dropping things. We have an important user now and everything <.<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the deprecation has been haphazard so far. If it's release based, I guess it'll have to be major releases. And we're not even at 1.0. 😁
No description provided.