Macos GitHub workflow #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BSD find requires the path even for current directory. No harm in providing it on GNU find too.
For some reason there's a /private prefix in the error messages on macOS that's not present in srcdir, nor on Linux. Just remove everything before and including the srcdir.
This will be useful for parser tests.
The parser may return None for clang diagnostics filename if there isn't one. Handle it gracefully by using get_message(basename=True) on the error.
Change the hyphen to underscore in update_examples.py, and call it as a module. This makes it easier for testenv.py to import stuff in the test directory.
Switch to argparse for parsing command-line arguments. Allow passing the language (compiler -x option) to use for figuring out the header search path. Translate 'cpp' to 'c++' for ease of use. Add a couple more useful output options in the CLI.
Add a pytest --cc-path command-line option to pass the compiler path to use for figuring out the search path. Move the clang args to conftest.py. For example: 'pytest -n auto --cc-path /path/to/clang'
Figure out the include paths for each domain (i.e. language, C or C++), and pass them to libclang. The C header search paths can be insufficient or plain wrong for C++. See https://reviews.llvm.org/D131441 for error messages that could be encountered.
Still hitting some issues.
|
Any C++ tests that despite the attempts to figure out the C++ header search path from the right compiler for the right language. The error messages were added in https://reviews.llvm.org/D131441 and the implication is that the include paths passed on the command-line are wrong... but then libclang does not figure them out itself, you have to pass them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#248 + the actual workflow.
Still fails, but it's a start.