chore(deps): Lock aioredis to <2 #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`aioredis` v2.0.0 has just been released: https://pypi.org/project/aioredis/2.0.0/ It breaks `aioredlock` with the following errors: ``` AttributeError: module 'aioredis' has no attribute 'create_redis_pool' AttributeError: module 'aioredis' has no attribute 'errors' ``` I propose to lock the `aioredis` version `aioredlock` requires to <2 (latest before v2.0.0 is v1.3.1).
bravier
changed the title
|
I don't really want to pin this. I would prefer to fix the usage and switch to using |
|
Okay I understand. I proposed to pin aioredis as a quick fix while waiting for a full support of v2.0.0. |
|
Thanks, we don't pin the version, so applications that are using it should be able to pin it, and not be overwritten. I am going to make sure to pin <3 when i finish fixing for support for 2.0.0 which hopefully i will be able to tomorrow. see #99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aioredisv2.0.0 has just been released:https://pypi.org/project/aioredis/2.0.0/
It breaks
aioredlockwith the following errors:I propose to lock the
aioredisversionaioredlockrequires to<2 (latest before v2.0.0 is v1.3.1).