Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite get_unet #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

rewrite get_unet #43

wants to merge 3 commits into from

Conversation

shartoo
Copy link

@shartoo shartoo commented Jun 30, 2017

i have just simplified the get_unet method to make the code more elegant, and nothing others changed.

@jocicmarko
Copy link
Owner

jocicmarko commented Jul 14, 2017

Hi @shartoo , thank you for your PR.
Although this simplifies the code a bit indeed and makes it easier to maintain, this repository was primarily created for people who are beginners in deep learning and Keras. Thus, even though the original code is more cumbersome and not so modular as in your PR, it makes it easier to understand the architecture and correlate it with the picture of the U-Net.

Personally, I also use code similar to yours and in the long run it's much better, but for the sake of beginners' sanity I won't merge this PR. However, I will leave it open, so anyone interested in making their code more modular can take a look at your example.

Again, thank you for understanding,
Marko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants