Generate Method Names in "$ref" Properties Using a "javaName" #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties with a "javaName".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR here, please help me out with anything else that might be required.
This is my attempt at addressing #678. It works by injecting the
javaNamevalue from a parent node that uses$refinto a copy of the referenced node.As a weirdness, without the changes to
PropertyRule.javathe updated test fails on line 69hasProperty("javaReference"), which is confusing to me. A property with the namejavaReferencedoes exist on the actual object if you enter a debugger, but for some reasonhamcrest.beans.PropertyUtilsees a different set of property names. I'm not sure why that is.