Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for multiple tbody tags #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brendanmckeown
Copy link

I needed to sort a table with multiple tbody tags, so I've modified the sorting method to handle this. Also, I needed to exclude a row from the sort, so I've added a filter to exclude tr's with the data attribute "data-sort-ignore".

@mikejolley
Copy link

(y) Need this too

@joequery
Copy link
Owner

I wanted to verify if multiple tbody tags is valid HTML, and it is:

http://www.w3.org/TR/html-markup/table.html#table

Permitted contents
An optional caption element, followed by zero or more colgroup elements, followed by an optional thead element, followed by ... zero or more tbody elements or one or more tr elements ...

I'll look into implementing these changes soon, thank you.

@tomsommer
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants