Commenting out requestCacheNames request until the issue is understood

joffrey-bion · Apr 24, 2023 · 8437cf8 · 8437cf8
1 parent 3f61447
commit 8437cf8
Showing 1 changed file with 15 additions and 10 deletions.
diff --git a/src/test/kotlin/IntegrationTests.kt b/src/test/kotlin/IntegrationTests.kt
@@ -7,10 +7,10 @@ import org.hildan.chrome.devtools.domains.dom.*
 import org.hildan.chrome.devtools.domains.domdebugger.DOMBreakpointType
 import org.hildan.chrome.devtools.domains.domdebugger.SetDOMBreakpointRequest
 import org.hildan.chrome.devtools.domains.runtime.evaluateJs
-import org.hildan.chrome.devtools.domains.storage.GetCookiesRequest
 import org.hildan.chrome.devtools.domains.target.GetTargetsRequest
 import org.hildan.chrome.devtools.protocol.ChromeDPClient
 import org.hildan.chrome.devtools.protocol.ExperimentalChromeApi
+import org.hildan.chrome.devtools.protocol.RequestFailed
 import org.hildan.chrome.devtools.targets.*
 import org.testcontainers.containers.GenericContainer
 import org.testcontainers.junit.jupiter.Container
@@ -159,19 +159,21 @@ class IntegrationTests {
         runBlockingWithTimeout {
             chromeDpClient().webSocket().use { browser ->
                 browser.attachToNewPage().use { page ->
-
-                    // the following usages should not fail
-                    page.cacheStorage.requestCacheNames(RequestCacheNamesRequest("google.com"))
+                    // Commenting this one out until the issue is better understood
+                    // https://github.com/joffrey-bion/chrome-devtools-kotlin/issues/233
+                    //page.cacheStorage.requestCacheNames(RequestCacheNamesRequest("google.com"))
                     page.backgroundService.clearEvents(ClearEventsRequest(ServiceName.backgroundFetch))
                     page.browser.getVersion()
                     page.css.getMediaQueries()
                     page.database.enable()
                     page.debugger.disable()
                     page.deviceOrientation.clearDeviceOrientationOverride()
-                    page.domDebugger.setDOMBreakpoint(SetDOMBreakpointRequest(
-                        nodeId = page.dom.getDocumentRootNodeId(),
-                        type = DOMBreakpointType.`attribute-modified`,
-                    ))
+                    page.domDebugger.setDOMBreakpoint(
+                        SetDOMBreakpointRequest(
+                            nodeId = page.dom.getDocumentRootNodeId(),
+                            type = DOMBreakpointType.`attribute-modified`,
+                        )
+                    )
                     page.domSnapshot.enable()
                     page.domStorage.enable()
                     page.fetch.disable()
@@ -183,6 +185,7 @@ class IntegrationTests {
                     page.profiler.disable()
 
                     val supportedByCode = RenderFrameTarget.supportedDomains.toSet()
+
                     // We can replace this schema Domain call by an HTTP call to /json/protocol
                     // The Kotlin definitions of that JSON from the buildSrc should work for this,
                     // but we need a way to share them between test and buildSrc
@@ -192,10 +195,12 @@ class IntegrationTests {
                         "ApplicationCache", // was removed in tip-of-tree, but still supported by the server
                     )
                     val onlyInServer = supportedByServer - knownUnsupportedDomains - supportedByCode
-                    assertEquals(emptySet(),
+                    assertEquals(
+                        emptySet(),
                         onlyInServer,
                         "The library should support all domains that the zenika/alpine-chrome container actually " +
-                            "exposes (apart from $knownUnsupportedDomains)")
+                                "exposes (apart from $knownUnsupportedDomains)"
+                    )
                 }
             }
         }