-
-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/emojis as project icons #3575
base: master
Are you sure you want to change the base?
Conversation
Hey there! Thank you very much for providing this PR! This is a really nice addition and I'd very much like to see this Incorporated. I am wondering however if there maybe is an alternative route we can go, because What do you think? Would be using only native utf emojis also be a possible option? On a further note: I had a little bit of difficulties getting to the emojis in the picker, since they only show up last. Maybe we can also improve on that. |
Hey, I used it because of 2 main advantages:
I don't support using native emojis, so it's up to you if you want to go forward with this PR, I did use a heavy dependency without consulting you so that's on me too. |
Hey there @stavby ! I spent quite some time thinking about this. I am all for adding basic unicode icons (which we could extract from here: https://github.com/missive/emoji-mart/blob/main/packages/emoji-mart-data/sets/5/native.json), but adding such a big dependency (the apple icons alone are 4.2MB) doesn't feel right to me personally. Using this would also affect the user data the app saves, which would make migrating away, when needed, all the more difficult. Unicode icons on the other hand, are a widely used (though a bit inconsistent) standard. I am very sorry for the time you sunk into this and I hope you can understand my reasoning. It would be great if you could rework the PR, but I also would totally understand if you choose not to. Not sure if I am overlooking anything, but in my head a possible implementation would work like this:
Alternatively we could add a dedicated picker just listing all the unicode icons, such as messengers like whatsapp do. What do you think? |
Description
Add the option to use emojis as project and tag icons:
(I also fixed a test in the last commit - the test date has passed and it started failing because of that, I moved the date to 2030 so it stays on saturday and won't pass soon)
Issues Resolved
#3558
Check List