[WIP] Find julia installation #100
Conversation
This allows searchin for an installed Julia exectuable.
|
I am using this approach in julia_project. This file is a copy of the code in this PR. I intend to remove it when this PR, or something like it, is merged into jill.py |
There was a problem hiding this comment.
Looks good... Just a few niche-picking comments.
Could you add a few lines of tests and insert them after
jill.py/.github/workflows/pythonapp.yml
Lines 53 to 61 in 3b2a29e
jill/install.py
Outdated
| found_installation = None | ||
| for preferred_installation in preferred_julia_installations: | ||
| if preferred_installation in installed_julias: | ||
| found_installation = preferred_installation | ||
| break |
There was a problem hiding this comment.
This is niche picking so it's okay to keep the current version; I personally feel it's better to return ALL paths that satisfy the requirement and let the callers decide which one is needed.
So for caller, it's perhaps easier to understand this way:
julia_paths = get_installed_bin_path(...)
if not julia_paths:
raise ValueError("Failed to found julia executables")
preferred_julia_path = julia_paths[0]There was a problem hiding this comment.
Good idea. But, the versions will be buried in the path to the executable. I'll push a version that returns a dict of executable paths keyed on version. See what you think of that.
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 61.00% 59.72% -1.29%
==========================================
Files 16 16
Lines 1349 1383 +34
Branches 254 292 +38
==========================================
+ Hits 823 826 +3
- Misses 431 462 +31
Partials 95 95
Continue to review full report at Codecov.
|
|
The last commit takes care of some issues. I have not yet added tests. |
| Return a dict whose keys are Julia version strings and whose values are | ||
| absolute paths to the corresponding Julia exectuable. Only jill.py's | ||
| default directory for Julia installations is searched. | ||
| The version strings either equal to `latest` or have the form `major.minor`. |
There was a problem hiding this comment.
If my memory serves well, there can be a third case julia-dev if you install the dev version Julia via jill install 1.8.0+848d273.
This PR adds
get_installed_bin_path(preferred_versions=None, only_preferred=False).It may be called like this
to find the path the the exectuable of the first preferred Julia version found, or otherwise, the first Julia version found.
See #99