Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ukrainian currency provider #2141

Merged

Conversation

SaulTigh
Copy link
Contributor

@SaulTigh SaulTigh commented Nov 19, 2024

What does this change

Added Ukrainian currency provider.

What was wrong

--

How this fixes it

--

Checklist

  • I have read the documentation about CONTRIBUTING
  • I have read the documentation about Coding style
  • I have run make lint

@SaulTigh SaulTigh marked this pull request as ready for review November 19, 2024 08:23
@SaulTigh
Copy link
Contributor Author

@fcurella FYI: i've run make lint, but generate_stubs didn't work as expected on my py3.12 virtualenv, so excluded result of that script from changeset

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit d72db54 into joke2k:master Jan 3, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants