Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed route paths and names to use user group names #103

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

critch646
Copy link
Collaborator

Problem
The route paths and names were domain specific and unorganized.

Solution

  • Renamed the route paths and names to use user group names. This helps group the routes by stakeholders.
  • Added tags to the routes to help group them by user group.
  • Updated the web app to use the new route paths and names.
  • Updated the tests to use the new route paths and names.

Ticket URL
NA

Documentation
NA

Tests Run

  • make test-web
  • yarn build
  • manual testing of web app
  • docker compose up testapi

Problem
The route paths and names were domain specific and unorganized.

Solution
- Renamed the route paths and names to use user group names. This
helps group the routes by stakeholders.
- Added tags to the routes to help group them by user group.
- Updated the web app to use the new route paths and names.
- Updated the tests to use the new route paths and names.

Ticket URL
NA

Documentation
NA

Tests Run
- make test-web
- yarn build
- manual testing of web app
- docker compose up testapi
@critch646 critch646 requested a review from MadelaineJ February 15, 2024 01:50
Copy link
Collaborator

@MadelaineJ MadelaineJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. one minor import nit pick

app/api/routes/intakes/delete_intake_uuid.py Outdated Show resolved Hide resolved
app/api/routes/intakes/get_intake_uuid.py Outdated Show resolved Hide resolved
@critch646 critch646 merged commit bee8f0c into main Feb 15, 2024
@critch646 critch646 deleted the zeke/dev/route-renaming branch February 15, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants