Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeder dependency missing #66

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Seeder dependency missing #66

merged 1 commit into from
Jan 17, 2024

Conversation

critch646
Copy link
Collaborator

@critch646 critch646 commented Jan 17, 2024

Problem
Seeder service fails to run because of missing dependency.

Solution

  • update seeder_reqs.txt to include SQLAlchemy-Utils==0.41.1

Ticket URL
https://mediform.atlassian.net/browse/MEDI-22

Documentation
NA

Tests Run
Rebuilt seeder container and ran seeder service.
Seeder service ran successfully.

@critch646 critch646 requested a review from MadelaineJ January 17, 2024 21:21
Copy link
Collaborator

@MadelaineJ MadelaineJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good but you're missing a commit message I think. It's just "Problem"
image

Problem
Seeder service fails to run because of missing dependency.

Solution
- update seeder_reqs.txt to include SQLAlchemy-Utils==0.41.1

Ticket URL
https://mediform.atlassian.net/browse/MEDI-22

Documentation
NA

Tests Run
Rebuilt seeder container and ran seeder service.
Seeder service ran successfully.
@critch646 critch646 force-pushed the zeke/dev/seeder-dependency branch from 6374c34 to 0ecb4ce Compare January 17, 2024 22:06
@critch646 critch646 requested a review from MadelaineJ January 17, 2024 22:09
Copy link
Collaborator

@MadelaineJ MadelaineJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@critch646 critch646 merged commit f699b48 into main Jan 17, 2024
@critch646 critch646 deleted the zeke/dev/seeder-dependency branch January 17, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants