Sort continuous aggregates when dumping to the schema #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the schema dumper output consistent by sorting the continuous aggregates by the view name, otherwise the schema can get a random diff depending on the rows order returned by the DB. ``` > Timescaledb::ContinuousAggregates.order(:view_name).pluck(:view_name) Timescaledb::ContinuousAggregate Pluck (5.9ms) SELECT "timescaledb_information"."continuous_aggregates"."view_name" FROM "timescaledb_information"."continuous_aggregates" ORDER BY "timescaledb_information"."continuous_aggregates"."view_name" ASC ```
|
Hi @carlosantoniodasilva, thank you very much for your contribution. It will not be simple as that because of the dependencies. I have already the PR open and forgot to push it forward and merge it. Check #70 for understanding the real issue. I'll make sure I include your consideration of also sorting by view name as you did it. Will push it forward soon 🤞 |
|
Cool, appreciate it @jonatas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the schema dumper output consistent by sorting the continuous aggregates by the view name, otherwise the schema can get a random diff depending on the rows order returned by the DB.
The hypertables (and the retention policies which are based on them) are already sorted and create a consistent schema output.