Skip to content

Commit

Permalink
Corrected Android 12 dark parameters not defaulting to light paramete…
Browse files Browse the repository at this point in the history
…rs. Thanks elliotrtd for the heads up on this issue.
  • Loading branch information
jonbhanson committed Oct 30, 2022
1 parent e4b29f8 commit a91dc4b
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 10 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## [2.2.13] - (2022-Oct-30)

- Corrected Android 12 dark parameters not defaulting to light parameters. Thanks [elliotrtd](https://github.com/elliotrtd) for the [heads up](https://github.com/jonbhanson/flutter_native_splash/issues/400#issuecomment-1235100173) on this issue.

## [2.2.12] - (2022-Oct-23)

- Updated readme and dependancies.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ First, add `flutter_native_splash` as a dependency in your pubspec.yaml file.

```yaml
dependencies:
flutter_native_splash: ^2.2.12
flutter_native_splash: ^2.2.13
```
Don't forget to `flutter pub get`.
Expand Down
18 changes: 10 additions & 8 deletions lib/cli_commands.dart
Original file line number Diff line number Diff line change
Expand Up @@ -142,22 +142,24 @@ void createSplashByConfig(Map<String, dynamic> config) {
darkImagePath: darkImageAndroid ?? darkImage,
brandingImagePath: brandingImageAndroid ?? brandingImage,
brandingDarkImagePath: brandingDarkImageAndroid ?? brandingDarkImage,
android12ImagePath: android12Image,
android12DarkImagePath: android12DarkImage,
android12IconBackgroundColor: android12IconBackgroundColor,
darkAndroid12IconBackgroundColor: darkAndroid12IconBackgroundColor,
android12BrandingImagePath: android12BrandingImage,
android12DarkBrandingImagePath: android12DarkBrandingImage,
backgroundImage: backgroundImageAndroid ?? backgroundImage,
darkBackgroundImage: darkBackgroundImageAndroid ?? darkBackgroundImage,
color: color,
darkColor: darkColor,
gravity: gravity,
brandingGravity: brandingGravity,
fullscreen: fullscreen,
android12DarkBackgroundColor: android12DarkColor,
android12BackgroundColor: android12Color,
screenOrientation: androidScreenOrientation,
android12ImagePath: android12Image,
android12DarkImagePath: android12DarkImage ?? android12Image,
android12BackgroundColor: android12Color,
android12DarkBackgroundColor: android12DarkColor ?? android12Color,
android12IconBackgroundColor: android12IconBackgroundColor,
darkAndroid12IconBackgroundColor:
darkAndroid12IconBackgroundColor ?? android12IconBackgroundColor,
android12BrandingImagePath: android12BrandingImage,
android12DarkBrandingImagePath:
android12DarkBrandingImage ?? android12BrandingImage,
);
} else {
print('Android folder not found, skipping Android splash update...');
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: flutter_native_splash
description: Customize Flutter's default white native splash screen with
background color and splash image. Supports dark mode, full screen, and more.
version: 2.2.12
version: 2.2.13
repository: https://github.com/jonbhanson/flutter_native_splash
issue_tracker: https://github.com/jonbhanson/flutter_native_splash/issues

Expand Down

0 comments on commit a91dc4b

Please sign in to comment.