Fix wrong command output #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command line application returns colors that include alpha channels even tho we specify RGB as a `quantize` option.
|
This looks similar to #32. |
|
Hi @chalmagean #33 fixes the issue by changing the command line param for image magick. I think its a bit cleaner, if you could verify it works on your system much appreciated. |
|
Sorry, I don't have a way to test this atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a test case (and fix) that handles the wrong number of characters in the string returned from the command line app. Even though I have the
quantizeoption set toRGB, I still get rgba values back.Maybe this is because of a newer version of ImageMagick... I'd have to investigate more.