Make sure when detecting partition type that we do not overread over …

…a struct and cause crashes
joncampbell123 · Sep 9, 2023 · 2051bf1 · 2051bf1
1 parent fa8295c
commit 2051bf1
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/ints/bios_disk.cpp b/src/ints/bios_disk.cpp
@@ -3572,6 +3572,9 @@ bool PartitionLoadIPL1(std::vector<_PC98RawPartition> &parts,imageDisk *loadedDi
 std::string PartitionIdentifyType(imageDisk *loadedDisk) {
 	struct partTable mbrData;
 
+	if (loadedDisk->getSectSize() > sizeof(mbrData))
+		return std::string(); /* That would cause a buffer overrun */
+
 	if (loadedDisk->Read_Sector(0,0,1,&mbrData) != 0)
 		return std::string();