Remove useless fcntl() on some memory location typecast as int code, …

…it is causing crashes on Windows [#4994]
joncampbell123 · Jun 7, 2024 · 6b42bac · 6b42bac
1 parent 4cb3201
commit 6b42bac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,4 +1,7 @@
 Next:
+  - Remove unnecessary and useless Win32 fcntl() on some memory typecast
+    to int which is causing a segfault whenever a ZIP file is mounted
+    as a drive with an overlay filesystem atop it. (joncampbell123)
   - Update caption control feature to use equivalent APIs on Mac OS. (joncampbell123)
   - Add dosbox.conf and menu option to control whether the DOSBox-X window
     can be seen in screen captures in Windows 7/8/10/11. Windows 11 "Recall"

diff --git a/src/dos/drive_physfs.cpp b/src/dos/drive_physfs.cpp
@@ -817,9 +817,6 @@ bool physfsFile::prepareWrite() {
 		//LOG_MSG("noCOW",pname,PHYSFS_tell(fhandle));
 		PHYSFS_close(fhandle);
 		fhandle = PHYSFS_openAppend(pname);
-#ifndef WIN32
-		fcntl(**(int**)fhandle->opaque,F_SETFL,0);
-#endif
 		PHYSFS_seek(fhandle, pos);
 	}
 	return true;