Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set usescancodes=true when non-US keyboards are detected (Linux/MacOS builds) #4333

Merged
merged 6 commits into from
Jul 17, 2023

Conversation

maron2000
Copy link
Contributor

With this PR, If usescancodes=auto (default), it is set to true when using non-US keyboards in Linux SDL1 builds.
This behavior is consistent with what is mentioned in dosbox-x-reference.conf, and the same is already set for Windows build in PR #4037.

@maron2000 maron2000 changed the title Set usescancodes=true when non-US keyboards are detected (Windows builds) Set usescancodes=true when non-US keyboards are detected (Linux builds) Jun 13, 2023
@Torinde
Copy link
Contributor

Torinde commented Jun 14, 2023

Is that needed also for macOS and HX DOS?

@maron2000
Copy link
Contributor Author

Well certainly yes, I don't know how to do it for those OSs.
However it is not a must but is better to be fixed.

@maron2000 maron2000 changed the title Set usescancodes=true when non-US keyboards are detected (Linux builds) Set usescancodes=true when non-US keyboards are detected (Linux/MacOS builds) Jun 16, 2023
@joncampbell123 joncampbell123 merged commit 14e103a into joncampbell123:master Jul 17, 2023
12 checks passed
@maron2000 maron2000 deleted the usescancodes branch July 18, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants