Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HX-DOS fix pre-upload testing failure #4451

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

maron2000
Copy link
Contributor

HX-DOS builds tests itself by running it on VS builds before Release/Development builds are uploaded.
Upon building release versions, test may fail because VS release builds are yet to be built and missing, therefore wait for sometime to finish building it.

HX-DOS version tests itself by running it on a VS build so wait until it is built.
@joncampbell123 joncampbell123 merged commit c3fd9cb into joncampbell123:master Sep 5, 2023
17 checks passed
@Torinde
Copy link
Contributor

Torinde commented Sep 5, 2023

Let's see how it goes. Last run seems to be ~50mins, so I would suggest to put a delay of 1 hour, just to be sure?
image

@maron2000
Copy link
Contributor Author

Actual required time to build 32bit VS builds is around 25min. but sometimes jobs get queued for sometime.
You need 15-20min. for the HX-DOS build to finish, and wait additional 40 min. which means around 55-60min., so it shouldn't be so short.
If we often see VS builds to take more than an hour, we may omit the testing since it is tested every time it is committed during the development stage.

@maron2000 maron2000 deleted the hxdos_fix branch September 5, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants