Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings to IMGMOUNT command #4498

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

maron2000
Copy link
Contributor

This PR warns users if trying to mount an unformatted drive or image files with unsupported extensions.

imgmount_warnings

@rderooy
Copy link
Contributor

rderooy commented Sep 29, 2023

I did not check the code, but did you test this with PC booter games that do not have a FAT file system? Or is this only meant to work on HDD images?

@maron2000
Copy link
Contributor Author

This PR is merely a warning and will never reject mounting due to whether it is FAT formatted or not.
The unformatted warning will show only when you IMGMOUNT with drive letters, and if the game is not FAT formatted, I believe you have to mount it with drive numbers.
I can try if you can raise a paricular game in mind.

@joncampbell123 joncampbell123 merged commit 5eea489 into joncampbell123:master Sep 30, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants